RevEng: Don't produce HasIndex() API if it would already be assumed #4039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supporting a primary key, but make allowance for the outputting HasName() (on a primary key) or HasConstraintName() (on a foreign key) as needed.
| @@ -14,7 +14,8 @@ namespace E2E.Sqlite | |||
| { | |||
| modelBuilder.Entity<OneToManyDependent>(entity => | |||
| { | |||
| entity.HasKey(e => new { e.OneToManyDependentID1, e.OneToManyDependentID2 }); | |||
| entity.HasKey(e => new { e.OneToManyDependentID1, e.OneToManyDependentID2 }) | |||
| .HasName("sqlite_autoindex_OneToManyDependent_1"); | |||
There was a problem hiding this comment.
Can we suppress this behavior for SQLite? SQLite ignores attempts to set the constraint name on the primary key.
CREATE TABLE People ( Id INT, CONSTRAINT "PK_People" PRIMARY KEY ( Id ) );
-- done.
SELECT * FROM sqlite_master;
-- shows the index created is named "sqlite_autoindex_People_1"There was a problem hiding this comment.
Discussed this with @natemcmaster offline. SQLite won't do anything with it this extra API and it should cause no problems. This seems to be something we should address in a SQLite-specific codegen layer, but we don't have that at the moment pending decisions in #4038. So checking in as is. Will discuss as part of #4038.
|
|
|
Checked in with commit dbb5c9f. |
smitpatel
deleted the
151210-lajones_DontGenerateUnnecessaryIndexes_02
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to supporting a primary key, but make allowance for the outputting
HasName() (on a primary key) or HasConstraintName() (on a foreign key) as needed.
Fix for #3710.